feat(elements): Add support for redirect_url URL parameter#3906
Merged
Conversation
🦋 Changeset detectedLatest commit: 285fce1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
approved these changes
Aug 6, 2024
alexcarpenter
approved these changes
Aug 6, 2024
|
This doesn't work with absolute URLs, only relative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
?redirect_urlin Elements to both sign in and sign up.Testing Instructions
http://localhost:3000/sign-in?redirect_url=/404http://localhost:3000/404?redirect_url=%2F404Notes
It really feels like this behavior should be delegated to
clerk-js, possibly in the form of updatingbuildAfterSignInUrlto take in parameters such asredirect_url. CurrentlybuildAfterSignInUrlonly captures parameters when Clerk is initialized, not at the time of authentication.Fixes SDKI-295
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change